remove all farcaster frame logic for the moment #5213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jnsdls
added
DO NOT MERGE
Contributor
size-limit report 📦
|
joaquim-verges
approved these changes
Oct 28, 2024
jnsdls
changed the base branch from
Refactor_Farcaster_frame_validation
to
graphite-base/5213
Contributor
Merge activity
|
graphite-app
bot
requested review from
arcoraven and
gregfromstl
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5213 +/- ##
=======================================
Coverage 45.26% 45.26%
=======================================
Files 1067 1067
Lines 55347 55347
Branches 3971 3971
=======================================
Hits 25054 25054
Misses 29601 29601
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
jnsdls
force-pushed
the
10-28-remove_all_farcaster_frame_logic_for_the_moment
branch
from
698ad3c to
27e1c87
Compare
<!-- start pr-codex -->
## PR-Codex overview
This PR primarily focuses on the removal of multiple files related to Farcaster frames and the `@coinbase/onchainkit` package, as well as some metadata updates in the `package.json` and `pnpm-lock.yaml` files.
### Detailed summary
- Deleted various files related to Farcaster frames and their functionality.
- Removed the `shortenAddress` function from `apps/dashboard/src/utils/string.ts`.
- Updated `package.json` to remove `@coinbase/onchainkit` dependency.
- Cleaned up `pnpm-lock.yaml` by removing references to deleted packages and dependencies.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
10-28-remove_all_farcaster_frame_logic_for_the_moment
branch
from
27e1c87 to
6cb66c6
Compare
graphite-app
bot
deleted the
10-28-remove_all_farcaster_frame_logic_for_the_moment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on the removal of various files and code segments related to the
Farcasterframes and related functionalities in thedashboardapplication, streamlining the codebase by eliminating outdated or unused components.Detailed summary
api.tstx-frame.tsWarpcast.tsconnect-frames.tsSuperChainFrame.tsengine.tsmint.tsxshortenAddressfunction fromstring.ts.Farcaster frames headersfromGrantSuperChainandConnectLandingcomponents insuperchain.tsxandconnect.tsxrespectively.pnpm-lock.yamlby removing references to deleted packages.